build macos arm64 wheels #1935
Merged
build macos arm64 wheels #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1935 +/- ##
==========================================
+ Coverage 82.93% 90.96% +8.03%
==========================================
Files 125 94 -31
Lines 13755 9479 -4276
Branches 1877 1877
==========================================
- Hits 11408 8623 -2785
+ Misses 2075 584 -1491
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ctb
approved these changes
Apr 8, 2022
luizirber
force-pushed
the
lirber/macos_crossbuild
branch
from
316176e
to
bd23914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous try (in #1334) tried to build
universal2wheels on mac, but that's complicated. This PR builds two separated wheels, one forarm64, another forx86_64, and letpipchoose the correct one during installation.I also updated
cibuildwheelto list configuration inpyproject.toml, this way it can also be tested locally.(In preparation for fixing the currently broken
sourmash-minimalpackage onconda-forge, which is not doing the cross-compilation properly).